emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 4d00db5 8/8: Remove compat code from comint.el


From: Basil L. Contovounesios
Subject: Re: master 4d00db5 8/8: Remove compat code from comint.el
Date: Wed, 12 Aug 2020 08:29:59 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 4d00db5538dc0ef47cf1cdf425b895d04145fe9e
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Remove compat code from comint.el
>     
>     * lisp/comint.el (make-comint-in-buffer): `start-file-process' is
>     always defined, so remove test.
> ---
>  lisp/comint.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lisp/comint.el b/lisp/comint.el
> index df947b9..843cba1 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -735,8 +735,6 @@ contents are sent to the process as its initial input.
>  If PROGRAM is a string, any more args are arguments to PROGRAM.
>  
>  Return the (possibly newly created) process buffer."
> -  (or (fboundp 'start-file-process)
> -      (error "Multi-processing is not supported for this system"))
>    (setq buffer (get-buffer-create (or buffer (concat "*" name "*"))))
>    ;; If no process, or nuked process, crank up a new one and put buffer in
>    ;; comint mode.  Otherwise, leave buffer and existing process alone.

Perhaps the code here and in the previous commit meant to check for
(fboundp 'make-process) instead?  start-file-process may always be
defined, but I don't recall all platforms supporting subprocesses.  Or
is this check no longer deemed necessary?

Thanks,

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]