[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Okay to commit purely cosmetic (indendation) fixes?
From: |
Eli Zaretskii |
Subject: |
Re: Okay to commit purely cosmetic (indendation) fixes? |
Date: |
Mon, 10 Aug 2020 18:51:40 +0300 |
> Cc: emacs-devel@gnu.org
> From: Clive Tovero <clive.tovero@aol.com>
> Date: Mon, 10 Aug 2020 11:39:10 -0400
>
> > Yes. They make whole lines look like due to someone who only changed
> > the whitespace.
>
> Thank you, I had heard the recommendation to not make whitespace-only
> commits, I didn't understand why. I guess I would have to know what
> tools you are using and what task you are doing to completely
> understand--many diff tools are capable of ignoring whitespace changes
> and highlighting whitespace. If you are looking at raw diff or
> something, I guess that would be a problem.
I had "git blame" in mind, and its Emacs equivalent "C-x v L".
> My use of "coding standard" was a poor choice of words, I'm sorry for
> that. I meant documentation of your software development process,
> including issues like this, a "Commiter's Guide" e.g. Then you could
> tell them please RTFM, and not lead to discussions like this.
In that case, please start with CONTRIBUTE in the top-level directory
of the Emacs source tree.
Re: Okay to commit purely cosmetic (indendation) fixes?, Clive Tovero, 2020/08/10