[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Okay to commit purely cosmetic (indendation) fixes?

From: Karl Fogel
Subject: Okay to commit purely cosmetic (indendation) fixes?
Date: Sun, 09 Aug 2020 15:49:25 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Are we okay with purely cosmetic commits to fix source-level formatting issues?

Specifically, in lisp/gnus/gnus-start.el, in `gnus-get-unread-articles', there 
is a multi-line `funcall' that is improperly indented.  Here's the fix I'd like 
to commit:

  --- lisp/gnus/gnus-start.el
  +++ lisp/gnus/gnus-start.el
  @@ -1637,10 +1637,10 @@ gnus-get-unread-articles
         ;; Only add groups that need updating.
         (if (or (and foreign-level (null (numberp foreign-level)))
  -        (funcall (if one-level #'= #'<=) (gnus-info-level info)
  -                 (if (eq (cadr method-group-list) 'foreign)
  -                     foreign-level
  -                   alevel)))
  +           (funcall (if one-level #'= #'<=) (gnus-info-level info)
  +                    (if (eq (cadr method-group-list) 'foreign)
  +                        foreign-level
  +                      alevel)))
          (setcar (nthcdr 2 method-group-list)
                  (cons info (nth 2 method-group-list)))
        ;; The group is inactive, so we nix out the number of unread articles.

The misindentation appears to have been introduced in commit 1f5eeb7be4ac, 
"Honor docstring of gnus-group-get-new-news" on 4 Feb 2016.  I ran across it 
while debugging a non-cosmetic problem related to the persistently undocumented 
`dont-connect' parameter, the details of which I won't go into here, but it led 
to the `info' variable in this function unexpectedly remaining `nil' since 
being first bound to `nil' in the surrounding `let*', and then 
`gnus-info-level' raising an error because it's being passed `nil' instead of a 
number... Anyway, I may or may not ever get to the bottom of that problem, 
since I found a workaround for my use case, but in the meantime I could at 
least fix the mis-indentation I found along the way.

Thoughts on cosmetic fixes in general and in this specific case?

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]