Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode

[Ted Zlatanov]

On Mon, 22 Jun 2020 16:03:31 -0400 Stefan Monnier <monnier@iro.umontreal.ca> 
wrote: 

>> +    (setq-local
>> +     prettify-symbols-compose-predicate #'auth-source-reveal-compose-p)

SM> This erases any prior configuration of that variable, so it won't "play
SM> ball" with other users.

Is it better do what tex-mode.el does?

  (add-function :override (local 'prettify-symbols-compose-predicate)
                #'tex--prettify-symbols-compose-p)

>> +  (prettify-symbols-mode (if auth-source-reveal-mode 1 -1)))

SM> And here we forcefully enable/disable `prettify-symbols-mode` even if
SM> all the user wanted if to hide the passwords.
SM> I think we need to decouple the two user-level features.

The plan was to make `prettify-symbols-mode' a library that other modes
like `auth-source-reveal-mode' can use. I went halfway, creating some
API-like functions. Are you suggesting that library is needed now to
avoid the tight coupling? Or something else?

Thanks
Ted