[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 80abaea: Use lexical-binding in lunar.el and add tests
From: |
Basil L. Contovounesios |
Subject: |
Re: master 80abaea: Use lexical-binding in lunar.el and add tests |
Date: |
Sat, 13 Jun 2020 19:52:24 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> stefankangas@gmail.com (Stefan Kangas) writes:
>
>> branch: master
>> commit 80abaea1d9c6f1e53fe88befe16de3b219cdd919
>> Author: Stefan Kangas <stefankangas@gmail.com>
>> Commit: Stefan Kangas <stefankangas@gmail.com>
>>
>> Use lexical-binding in lunar.el and add tests
>>
>> * lisp/calendar/lunar.el: Use lexical-binding.
>> (lunar-phases, diary-lunar-phases): Silence byte-compiler.
>> * test/lisp/calendar/lunar-tests.el: New file.
>
> I'm seeing the following test failure:
>
> cd test; make lunar-tests
[...]
> Test lunar-test-phase-list condition:
> (ert-test-failed
> ((should
> (equal
> (lunar-phase-list 3 1871)
> '...))
> :form
> (equal
> ((... "9:03pm" 0 "")
> (... "11:46pm" 1 "** Eclipse **")
> (... "7:20am" 2 "")
> (... "10:57pm" 3 "** Eclipse possible **")
> (... "12:06pm" 0 "")
> (... "4:49pm" 1 "")
> (... "3:57pm" 2 "")
> (... "7:29am" 3 "")
> (... "3:46am" 0 "")
> (... "6:02am" 1 ""))
> ((... "11:03pm" 0 "")
> (... "1:46am" 1 "** Eclipse **")
> (... "9:20am" 2 "")
> (... "12:57am" 3 "** Eclipse possible **")
> (... "2:06pm" 0 "")
> (... "6:49pm" 1 "")
> (... "5:57pm" 2 "")
> (... "9:29am" 3 "")
> (... "5:46am" 0 "")
> (... "8:02am" 1 "")))
> :value nil :explanation
> (list-elt 0
> (list-elt 1
> (arrays-of-different-length 6 7 "9:03pm" "11:03pm"
> first-mismatch-at 0)))))
[...]
> In case it matters, my time zone is
>
> (format-time-string "%Z %z") ; => "IST +0100"
Looks like I'm not the only one:
Tag a test as unstable
4823fa1077 2020-06-13 10:42:47 -0700
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4823fa1077e4330bd2574eb54731bb32e6370034
--
Basil