emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f0b0105: Hoist some byte-code checking out of eval


From: Stefan Monnier
Subject: Re: master f0b0105: Hoist some byte-code checking out of eval
Date: Wed, 20 May 2020 22:30:11 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>> My point is that 99% of the calls to `exec_byte_code` don't go through
>> `Fbyte_code`.
> Those other calls are also supposed to arrange for the relevant checks to be
> done, typically when the objects given to exec_byte_code were created. It
> saves some time to do the checks once on object creation rather than every
> time the byte code is called.

I understand, but looking at the patch and the comment message, I see
that you moved the checks from exec_byte_code to Fbyte_code and moved
duplicated *some* of the checks in make_byte_code but not all of them.

I probably missed something,


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]