emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Delete variables obsolete since Emacs 23


From: Stefan Monnier
Subject: Re: Delete variables obsolete since Emacs 23
Date: Sat, 16 May 2020 22:52:46 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> 3. Note the added FIXME in `vc-default-working-revision', where I'm not
>    sure if it should be declared obsolete or not.  See Stefan M's commit
>    6e5d0e9e73.

This function is never called directly (the only way it could be called
was via (vc-call-backend .. 'working-revision) for backends that
defined `vc-<backend>-workfile-revision` instead of
`vc-<backend>-working-revision`.

So a `make-obsolete` would have been ineffective (since it's never
called directly, the byte-compiler would never emit an obsolescence
warning) and I replaced it with a more annoying "message".  Since noone
complained about that message, I think it's definitely safe to remove
the function.

> 4. The variable `translation-table-for-input' was declared obsolete with
>    in Emacs 23.1 and has the following comment.  I'm not sure what to do
>    about it, if anything.
>
>    ;; This was introduced in 21.4 for pre-unicode unification.  That
>    ;; usage was rendered obsolete in 23.1, which uses Unicode internally.
>    ;; Other uses are possible, so this variable is not _really_ obsolete,
>    ;; but Stefan insists to mark it so.

It's not obsolete in the sense that there's nothing to replace
it, indeed.  But it's been completely unused since Emacs-23.1 so it's
complexity that's not pulling its weight.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]