emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcase.el: Add type pattern


From: Adam Porter
Subject: Re: [PATCH] pcase.el: Add type pattern
Date: Mon, 09 Mar 2020 17:46:18 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Michael Heerdegen <address@hidden> writes:

>>    (pred FUN)       matches if FUN called on EXPVAL returns non-nil.
>> +  (type TYPE)      matches if EXPVAL is of TYPE.
>>    (app FUN PAT)    matches if FUN called on EXPVAL matches PAT.
>
> I like your idea, but I would not document the new pattern at this
> prominent position.  Evaluating the pattern definition will add an entry
> in the dynamically created docstring anyway.  I think this is good
> enough.

Thanks, I forgot about that part of the docstring.  I removed that line
as you suggested in this updated patch.

Attachment: 0001-lisp-emacs-lisp-cl-macs.el-Add-type-pattern.patch
Description: Add pcase type pattern to cl-macs.el, etc.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]