[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] battery.el, upower fixes
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] battery.el, upower fixes |
Date: |
Mon, 27 Jan 2020 20:23:08 +0200 |
> From: Evgeny Zajcev <address@hidden>
> Date: Mon, 27 Jan 2020 02:04:30 +0300
>
> Fixes problems users experiencing with `battery-upower'.
>
> Also checks fore UPower is availability
Thanks, a couple of comments below, in addition to what Stefan wrote:
> -(defcustom battery-upower-device "battery_BAT1"
> +(defcustom battery-upower-device "DisplayDevice"
> "Upower battery device name."
> :version "26.1"
Please update the :version tag to 28.1, since you are changing the
default value for that version.
Also, I think if D-Bus is not compiled into Emacs, the default value
should be what we had before these changes.