[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master@head: completing-read behavior change?
From: |
T.V Raman |
Subject: |
Re: master@head: completing-read behavior change? |
Date: |
Thu, 23 Jan 2020 08:45:53 -0800 |
I just checked, emacspeak doesn't have explicit code for
icomplete. That said, I'll implement the more general approach you
suggest at some point -- likely by creating an Emacspeak-specific
minibuffer-contents equivalent. Is there some generic test I can use
to spot the new pattern vs old?
Dmitry Gutov writes:
> Hi T.V.,
>
> On 23.01.2020 3:03, T.V Raman wrote:
> > Fix is here for the curious:-)
> > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85
>
> You haven't answered my question about support for icomplete-mode. Do
> you only support Ido?
>
> I'm happy you made it work, but I think it would be better to handle the
> general approach. Meaning, instead of hardcoding the names of (private)
> variables, scan the minibuffer, look for the overlays with after-string,
> order by 'priority', and read their contents one after another.
>
> The new set-minibuffer-message feature uses the same approach if
> minibuffer is active. Although, in that case, you could advise this
> function, or set an alternative handler via the set-message-function
> variable (also just added in Emacs 27).
--
Id: kg:/m/0285kf1
--
Id: kg:/m/0285kf1
- master@head: completing-read behavior change?, T.V Raman, 2020/01/22
- Re: master@head: completing-read behavior change?, Dmitry Gutov, 2020/01/22
- Re: master@head: completing-read behavior change?, T.V Raman, 2020/01/22
- Re: master@head: completing-read behavior change?, T.V Raman, 2020/01/22
- Re: master@head: completing-read behavior change?, T.V Raman, 2020/01/22
- Re: master@head: completing-read behavior change?, Dmitry Gutov, 2020/01/23
- Re: master@head: completing-read behavior change?, T.V Raman, 2020/01/23
- Re: master@head: completing-read behavior change?, Dmitry Gutov, 2020/01/23
- Re: master@head: completing-read behavior change?,
T.V Raman <=
- Re: master@head: completing-read behavior change?, Dmitry Gutov, 2020/01/23
Re: master@head: completing-read behavior change?, T.V Raman, 2020/01/22