emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 32bd911: Simplify x-dnd.el due to bignums


From: Pip Cet
Subject: Re: master 32bd911: Simplify x-dnd.el due to bignums
Date: Sun, 5 Jan 2020 11:12:52 +0000

On Sun, Jan 5, 2020 at 3:07 AM Paul Eggert <address@hidden> wrote:
> diff --git a/lisp/x-dnd.el b/lisp/x-dnd.el
> index ea9d119..1272225 100644
> --- a/lisp/x-dnd.el
> +++ b/lisp/x-dnd.el
> @@ -545,14 +535,14 @@ FORMAT is 32 (not used).  MESSAGE is the data part of 
> an XClientMessageEvent."
>
>         ((eq size 4)
>          (if (eq byteorder ?l)
> -            (cons (+ (ash (aref data (+ 3 offset)) 8)
> -                     (aref data (+ 2 offset)))
> -                  (+ (ash (aref data (1+ offset)) 8)
> -                     (aref data offset)))
> -          (cons (+ (ash (aref data offset) 8)
> -                   (aref data (1+ offset)))
> -                (+ (ash (aref data (+ 2 offset)) 8)
> -                   (aref data (+ 3 offset))))))))
> +            (+ (ash (aref data (+ 3 offset)) 24)
> +               (ash (aref data (+ 2 offset)) 16)
> +               (ash (aref data (1+ offset)) 8)
> +               (aref data offset))
> +          (+ (ash (aref data offset) 24)
> +             (aref data (1+ offset) 16)

This should be (ash (aref data (1+ offset)) 16), I think.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]