[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Returning argument string (regexp-quote)
From: |
Mattias Engdegård |
Subject: |
Re: Returning argument string (regexp-quote) |
Date: |
Tue, 24 Sep 2019 19:44:21 +0200 |
24 sep. 2019 kl. 18.20 skrev Eli Zaretskii <address@hidden>:
>
>> More generally, do we need to preserve allocation for functions not
>> specifically documented to return new strings? I can imagine there being
>> code that depend on it by accident, but string mutation is rare.
>
> I think the benefits from such general changes are barely tangible,
> whereas the risk of breaking someone's (perhaps even ours) code are
> real. So I don't think we should do that, not in general.
Very well, I shan't go on a spree. What about the specific case of regexp-quote
then?
It was responsible for a sizeable portion of local consing in some (non-public)
code I was profiling.
Would the change need a mention in NEWS, and/or its doc string?
- Returning argument string (regexp-quote), Mattias Engdegård, 2019/09/24
- Re: Returning argument string (regexp-quote), Andreas Schwab, 2019/09/24
- Re: Returning argument string (regexp-quote), Eli Zaretskii, 2019/09/24
- Re: Returning argument string (regexp-quote),
Mattias Engdegård <=
- Re: Returning argument string (regexp-quote), Paul Eggert, 2019/09/24
- Re: Returning argument string (regexp-quote), Eli Zaretskii, 2019/09/24
- Re: Returning argument string (regexp-quote), Mattias Engdegård, 2019/09/25
- Re: Returning argument string (regexp-quote), Eli Zaretskii, 2019/09/25
- Compilation failure on macOS 10.15 Catalina, Zach Pearson, 2019/09/25
- Re: Compilation failure on macOS 10.15 Catalina, mituharu, 2019/09/25
- Re: Compilation failure on macOS 10.15 Catalina, Zach Pearson, 2019/09/25
- Re: Compilation failure on macOS 10.15 Catalina, mituharu, 2019/09/25
- Re: Compilation failure on macOS 10.15 Catalina, Zach Pearson, 2019/09/25
- Re: Compilation failure on macOS 10.15 Catalina, mituharu, 2019/09/25