Re: Tabs

[Stefan Kangas]

Hi Juri,

Juri Linkov <address@hidden> writes:

>>> Finally
>>
>> ... some ten years after you started ...

Thanks for working on this.  I think this feature would be an
important step forward for Emacs.  I've now checked out and built the
branch and report my findings below.

(FWIW, I find the names tab-bar-mode and global-tab-line-mode
confusingly similar.  Could we find better and more descriptive names?
 For example, global-tab-line-mode could be global-buffer-tab-mode.)

Are you also looking for input regarding potential improvements the
user interface at this stage?  For example, would feedback similar to
"I think the width of the tabs under tab-bar-mode should be fixed" be
helpful?

> 0. emacs -Q
> 1. M-x tab-bar-mode RET
> 2. Click on the plus sign to create a new tab
> 3. Click on the previous tab
> 4. Click on the close icon

When saying M-x tab-bar-mode here, the window flickers as if redrawing
but no tabs show up.  The tabs do show up as soon as I resize the
window, or move it to a different workspace.  (My window manager is
XMonad, a tiling window manager, and the Emacs frame is automatically
set to full screen and moved to a particular workspace after launch.
Not sure if that helps.)

I installed a tool that was available in Debian to capture my screen
while reproducing this bug.  I've uploaded the resulting video here:

https://drive.google.com/file/d/10-9DpKEseOUtYjrHUJ2bEMifvSOf98Ri/view

> 0. emacs -Q
> 1. M-x global-tab-line-mode
> 2. Click on the plus sign and select a buffer to create a new tab
> 3. Click on the previous tab
> 4. Click on the close icon

This basic use case seems to work for me.

My tabs don't look as sleek as yours; not sure why.  Please see the
attached screenshot.

These are my build details:

In GNU Emacs 27.0.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-09-02 built on joffe
Repository revision: 5bf45ec48b781a1165e882e7216892bf201d15f4
Repository branch: feature/tabs
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
 'configure --with-imagemagick
 PKG_CONFIG_PATH=/home/skangas/usr/lib/pkgconfig:'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB
NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD
PDUMPER LCMS2 GMP

Important settings:
  value of $LC_COLLATE: C
  value of $LC_CTYPE: sv_SE.UTF-8
  value of $LC_TIME: C
  locale-coding-system: utf-8-unix

Best regards,
Stefan Kangas

tabs-screenshot.png
Description: PNG image