[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bu
From: |
Lars Ingebrigtsen |
Subject: |
Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el |
Date: |
Wed, 31 Jul 2019 20:41:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Tassilo Horn <address@hidden> writes:
> when fixing bug#34160 you've reverted my changes that made json pretty
> printing use replace-region-contents. That had the major benefit that
> pretty printing the JSON object at point didn't move point. I use that
> many times a week on large JSON objects using the following command.
[...]
> AFAICS, the problem in bug#34160 was not caused by my changes (the user
> used Emacs 24 and not a 27 snapshot) so I see no justification for
> removing my feature.
The user referred to
"http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/json.el#n740",
which doesn't look like Emacs 24?
> Could you please reinstall the feature or describe why it is not
> feasible to keep it?
As the bug in question described -- pretty-printing a JSON region would
silently delete everything but the first JSON object, which doesn't seem
like optimal behaviour for a pretty-printing function.
If there's a problem where point is moved unnecessarily, then that
should be fixed, of course. Do you have a test case?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no