[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Proposed changes to gnus-notifications.el
From: |
Michael Albinus |
Subject: |
Re: Proposed changes to gnus-notifications.el |
Date: |
Sun, 21 Jul 2019 19:16:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
"Basil L. Contovounesios" <address@hidden> writes:
> In that case I think the proposed patch already behaves as it should,
> without changing existing behaviour. See the last few lines of the
> function gnus-notifications:
>
> (let* ((photo-file (gnus-notifications-get-photo-file address))
> (notification-id (gnus-notifications-notify
> (or (car address-components) address)
> (mail-fetch-field "Subject")
> photo-file)))
> (when notification-id
> ;; Register that we did notify this message.
> (push article (cdr group-notifications))
> ;; Register the notification ID for later actions.
> (setf (alist-get notification-id
> gnus-notifications-id-to-msg)
> (list group article)))
> ...)
>
> gnus-notifications-notify just calls notifications-notify, and the
> resulting ID is not assumed to be non-nil. Is this acceptable? Or did
> you mean something else when you said the patch assumes too much about
> notifications-notify?
Likely, it's ok (I didn't test on non GNU/Linux). Maybe we shall say,
that this works only for GNU/Linux systems with compiled D-Bus support.
> Thanks,
Best regards, Michael.
Re: Proposed changes to gnus-notifications.el, Lars Ingebrigtsen, 2019/07/21