[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ELPA] New package: phps-mode

From: Christian Johansson
Subject: Re: [ELPA] New package: phps-mode
Date: Wed, 17 Jul 2019 07:43:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0


Thanks for your review, I should have fixed all those items now and pushed them to ELPA

Best Regards

On 2019-07-16 12:00, Mattias Engdegård wrote:
Thank you for your contribution! A regexp scan on phps-mode, using relint, 
found some irregularities. Summary here, along with some things that relint 
didn't catch:

(defvar phps-mode-lexer-TOKENS "[][;\\:,\.()|^&+-/*=%!~\\$<>?@]"

The hyphen (-) is special and should be placed last to avoid being interpreted 
as a range.

The lone backslash in front of the dot has no effect, since backslashes must be 
doubled inside string literals.
On the regexp level, backslashes are not special inside [...] and only 
represent themselves, with no escaping power. This regexp includes it multiple 
times which was probably unintended.

                    (if (looking-at "[^\\\\]\"")

No need to double the backslash; it's not special inside [...].


Hex and octal escapes in the 128-255 range do not denote Unicode (Latin-1) characters but raw 
bytes, which you likely did not intend to match here. To match U+0080-U+00FF, write 
"\u0080-\u00FF". I don't know PHP's lexing rules, but if you want to match Unicode 
identifiers, you'd be better off using something like "[[:alpha:]_][[:alnum:]_]*", or 
syntax classes.

             (when (looking-at-p " \\*\/")

Ineffective backslash before `/', which does not need escaping anyway.
The same pattern (`\/') occurs in several other places in this file.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]