[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Crashes in "C-h h"

From: Eli Zaretskii
Subject: Re: Crashes in "C-h h"
Date: Wed, 03 Jul 2019 07:28:13 +0300

> From: Paul Eggert <address@hidden>
> Date: Tue, 2 Jul 2019 19:38:00 -0700
> Cc: address@hidden
> Pip Cet wrote:
> > Is there a problem simply testing FIXNUMP in this place?
> As Eli's revised code suggests, if n is in fixnum range, then instead of 
> (FIXNUMP (x) && XFIXNUM (x) == n) it's typically a bit cleaner (and faster) 
> to 
> write EQ (x, make_fixnum (n)).

It normally shouldn't matter either way, but in that case the
comparison is done in a loop, so the make_fixnum call can be done just
once, outside the loop, which AFAIU makes the loop a tad faster.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]