[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Add module functions to convert from and to big integers
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 2/2] Add module functions to convert from and to big integers. |
Date: |
Wed, 24 Apr 2019 19:03:23 +0300 |
> From: Philipp Stephani <address@hidden>
> Cc: Philipp Stephani <address@hidden>
> Date: Tue, 23 Apr 2019 23:32:18 +0200
>
> * src/module-env-27.h: Add new module functions to convert big
> integers.
>
> * src/emacs-module.h.in (emacs_mpz): Define if GMP is available.
>
> * src/emacs-module.c (module_extract_big_integer)
> (module_make_big_integer): New functions.
> (initialize_environment): Use them.
>
> * test/data/emacs-module/mod-test.c (Fmod_test_double): New test
> function.
> (emacs_module_init): Define it.
>
> * test/src/emacs-module-tests.el (mod-test-double): New unit test.
>
> * doc/lispref/internals.texi (Module Values): Document new functions.
These changes break the Emacs build on platforms where GMP is not
available and Emacs uses mini-gmp.c. In particular, lisp.h amd
emacs-module.c unconditionally define EMACS_MODULE_GMP, which then
causes emacs-module.h include gmp.h, whose defionitions conflict with
mini-gmp.h.
It is also not clear whether the new emacs-module facilities are
compatible with mini-gmp, i.e. whether mini-gmp can support the above
interfaces in emacs-module. because if they can, we have a problem:
emacs-module.h cannot include mini-gmp.h, AFAIU, where the relevant
structures and macros are defined instead of system-wide gmp.h.
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., (continued)
Re: [PATCH 1/2] Add conversions to and from struct timespec to module interface., Paul Eggert, 2019/04/23
Message not availableRe: [PATCH 2/2] Add module functions to convert from and to big integers.,
Eli Zaretskii <=
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Eli Zaretskii, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Eli Zaretskii, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Eli Zaretskii, 2019/04/24
Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
[PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
Re: [PATCH] Unbreak build when building without GMP support., Eli Zaretskii, 2019/04/24
Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24