[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Using __builtin_expect (likely/unlikely macros)
From: |
Eli Zaretskii |
Subject: |
Re: Using __builtin_expect (likely/unlikely macros) |
Date: |
Sat, 20 Apr 2019 20:22:26 +0300 |
> From: Paul Eggert <address@hidden>
> Date: Sat, 20 Apr 2019 09:57:14 -0700
> Cc: address@hidden, address@hidden
>
> In this case the patch not only improved performance, it also made
> the code smaller and in my opinion more readable: the total source
> code size shrank by 1775 bytes.
I meant code in C, not the produced machine code, so the size is not
really relevant.
I'm not sure how do you see that the code became more readable: we now
have AVOID where previously we had _Noreturn, and ATTRIBUTE_COLD where
we previously had nothing. Both make the code slightly less readable,
IMO (because the reader must first learn what they mean).
- Re: Using __builtin_expect (likely/unlikely macros), (continued)
- Re: Using __builtin_expect (likely/unlikely macros), Andy Moreton, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Eli Zaretskii, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Eli Zaretskii, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros),
Eli Zaretskii <=
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Óscar Fuentes, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Óscar Fuentes, 2019/04/20
- Re: Using __builtin_expect (likely/unlikely macros), Paul Eggert, 2019/04/20