[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> fram
From: |
Alex Gramiak |
Subject: |
Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change |
Date: |
Tue, 16 Apr 2019 11:18:21 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Robert Pluim <address@hidden> writes:
> CC xdisp.o
> xdisp.c:29300:37: error: no member named 'x_highlight_frame' in
> 'struct ns_display_info'; did you mean 'ns_highlight_frame'?
> || f != FRAME_DISPLAY_INFO (f)->x_highlight_frame)
> ^~~~~~~~~~~~~~~~~
> ns_highlight_frame
> ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here
> struct frame *ns_highlight_frame;
> ^
> 1 error generated.
>
> (on macOS)
Ah, I originally renamed the x_highlight_frame on W32/NS to {w32,ns}_*,
but decided against it since xdisp.c used the attribute directly (a hook
or union interface could be added later). Perhaps it should be renamed
native_highlight_frame until then, though.
I pushed the fix, do you get any other errors/warnings on macOS?
Thanks for testing.
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/16
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change,
Alex Gramiak <=
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Eli Zaretskii, 2019/04/16
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Alex Gramiak, 2019/04/17
- Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change, Robert Pluim, 2019/04/17