[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Renaming non-X x_* identifiers
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Renaming non-X x_* identifiers |
Date: |
Mon, 15 Apr 2019 21:43:19 +0300 |
> From: Alex Gramiak <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Mon, 15 Apr 2019 11:46:18 -0600
>
> Is it okay that I left the get_focus_frame hook in do_switch_frame
> (frame.c) unchecked? It's enclosed by a FRAME_WINDOW_P, so a comment
> in termhooks.c mandating that window systems implement that hook
> should be sufficient, no? On the other hand, it's the only one
> remaining in the generic code that's left unchecked.
Yes, and we have others in the same situations which _are_ tested, for
example:
if (FRAME_WINDOW_P (f) && FRAME_TERMINAL (f)->frame_visible_invisible_hook)
FRAME_TERMINAL (f)->frame_visible_invisible_hook (f, true);
So I think we should do the same with get_focus_frame hook as well.
> Are there any other issues to discuss, besides the comments in
> termhooks.h (which I'll work on soon)? Have you tested this branch on
> w32 to check if I missed anything there?
I didn't yet try the to build the branch, no. I will try soon if no
one beats me to it. After you finish the comments, let's wait for a
few days so people could try the branch.
Thanks.
- Re: [PATCH] Renaming non-X x_* identifiers (was: Renaming non-X x_* procedures in xdisp.c (and elsewhere)), (continued)
- Re: [PATCH] Renaming non-X x_* identifiers (was: Renaming non-X x_* procedures in xdisp.c (and elsewhere)), Eli Zaretskii, 2019/04/13
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/13
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/13
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/13
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/14
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/14
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/14
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/14
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/15
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/15
- Re: [PATCH] Renaming non-X x_* identifiers,
Eli Zaretskii <=
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/16
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/24
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/25
- Re: [PATCH] Renaming non-X x_* identifiers, Eli Zaretskii, 2019/04/25
- Re: [PATCH] Renaming non-X x_* identifiers, Alex Gramiak, 2019/04/25