[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere)
From: |
Eli Zaretskii |
Subject: |
Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) |
Date: |
Sat, 13 Apr 2019 20:20:19 +0300 |
> From: Alex Gramiak <address@hidden>
> Cc: address@hidden
> Date: Sat, 13 Apr 2019 10:26:16 -0600
>
> > It's okay to add such a comment, although the _P part of the name,
> > which stands for "Predicate", is supposed to say that already.
>
> Right, I was just mildly concerned since the comment by it mentions that
> "it's defined to be the predicate for the window system being used",
> which might not be good for code to rely on in the very long-term.
>
> I removed that part of the comment in the patch series I just posted, is
> that an acceptable change?
If the comment no longer fits the code, then the comment should be
updated, sure.