[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new-flex-completion-style
From: |
Stefan Monnier |
Subject: |
Re: new-flex-completion-style |
Date: |
Mon, 18 Feb 2019 18:35:26 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> @@ -1801,7 +1801,9 @@ If FLAG is nil, invoke `try-completion'; if it is t,
> invoke
> else if (EQ (flag, Qlambda))
> return Ftest_completion (string, Vbuffer_alist, predicate);
> else if (EQ (flag, Qmetadata))
> - return list2 (Qmetadata, Fcons (Qcategory, Qbuffer));
> + return list3 (Qmetadata,
> + Fcons (Qcategory, Qbuffer),
> + Fcons (Qcycle_sort_function, Qidentity));
> else
> return Qnil;
> }
That easy, huh?
> * lisp/minibuffer.el (completion-all-sorted-completions): Don't
> re-sort if completion table has cycle-sort-function.
I think a more precise description would be that cycle-sort-function now
also overrides the use of minibuffer-history-variable.
[ "Don't re-sort" sounds like a mere optimization rather than a change
of semantics. ]
Other than that, LGTM,
Stefan
- RE: new-flex-completion-style, (continued)
- RE: new-flex-completion-style, Drew Adams, 2019/02/14
- Re: new-flex-completion-style, João Távora, 2019/02/14
- RE: new-flex-completion-style, Drew Adams, 2019/02/14
- Re: new-flex-completion-style, João Távora, 2019/02/14
- Re: new-flex-completion-style, Stefan Monnier, 2019/02/14
- RE: new-flex-completion-style, Drew Adams, 2019/02/14
- Re: new-flex-completion-style, Stefan Monnier, 2019/02/14
- Re: new-flex-completion-style, Dmitry Gutov, 2019/02/15
- RE: new-flex-completion-style, Drew Adams, 2019/02/15
- Re: new-flex-completion-style, João Távora, 2019/02/18
- Re: new-flex-completion-style,
Stefan Monnier <=
- Re: new-flex-completion-style, João Távora, 2019/02/19
- Re: new-flex-completion-style, Stefan Monnier, 2019/02/19
- Re: new-flex-completion-style, João Távora, 2019/02/19
- Re: new-flex-completion-style, Stefan Monnier, 2019/02/19
RE: new-flex-completion-style (was: [Emacs-diffs] scratch/ 2c75775 2/2: Score, sort and annotate flex-style completions according to match tightness), Drew Adams, 2019/02/11