Re: master e4896fc 1/2: Add a new 'flex' completion style

[Robert Pluim]

Unknown <address@hidden> writes:

> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index b757eb8..c1e3fdc 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -788,6 +788,11 @@ Additionally the user can use the char \"*\" as a glob 
> pattern.")
>  I.e. when completing \"foo_bar\" (where _ is the position of point),
>  it will consider all completions candidates matching the glob
>  pattern \"*foo*bar*\".")
> +    (flex
> +     completion-flex-try-completion completion-flex-all-completions
> +     "Completion of an in-order subset of characters.
> +When completing \"foo\" the glob \"*f*o*o*\" is used, so that
> +i.e. foo can complete to frodo.")

I think you can either drop the 'i.e.', or drop 'so that'.

>      (initials
>       completion-initials-try-completion completion-initials-all-completions
>       "Completion of acronyms and initialisms.
> @@ -3345,7 +3350,12 @@ the same set of elements."
>  ;;; Substring completion
>  ;; Mostly derived from the code of `basic' completion.
>  
> -(defun completion-substring--all-completions (string table pred point)
> +(defun completion-substring--all-completions
> +    (string table pred point &optional transform-pattern-fn)
> +  "Match the presumed substring STRING to the entries in TABLE.
> +Respect PRED and POINT.  The pattern used is a PCM-style
> +substring pattern, but it be massaged by TRANSFORM-PATTERN-FN, if
> +that is non-nil."

Iʼm all in favour of respect, but what does that mean in the context
of PRED and POINT?

What is 'PCM-style'? What does 'massaged' mean? What is the signature of
TRANSFORM-PATTERN-FN?

Robert