Re: [Emacs-diffs] master 7b31de4: Add hook for all events

[Phillip Lord]

Daniel Colascione <address@hidden> writes:

> On 1/22/19 1:46 PM, Phillip Lord wrote:
>> branch: master
>> commit 7b31de4d107302ed91ce7519cd778b340a9880ee
>> Author: Phillip Lord <address@hidden>
>> Commit: Phillip Lord <address@hidden>
>>
>>      Add hook for all events
>
> Why?


Finally got around to doing this 4 years after I first hit the problem.

https://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00742.html

Short answer: input methods break completion provided by both company
and my own pabbrev. For example, try copying the company-mode
documentation into *scratch*, M-x text-mode, M-x company-mode, M-x
set-input-method "italian-postfix". Now type "Comple". You should see
something like:


Compl
Complements
Complete
Completing
Completion
Complex
e_[]

where e_ is e underscore and [] is the cursor and the lines in the
middle are offered completions.

The problem is that company uses pre-command-hook to remove old offered
completions. But self-insert hasn't run yet, because the user hasn't
decided whether to type "e" or "e'". With this hook, I can pick up the
intermediate keypresses.

Does it cause any problems you can foresee (other than signally a lot).

Phil