Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it.

[João Távora]

Hi Alan,

Please revert this change ASAP:

commit 54f297904e0c641fcfd81f16e9a87177124a27be
Author: Alan Mackenzie
Date:   Thu Jan 17 12:51:40 2019 +0000

    Temporarily comment out CC Mode from tests which are incompatible
with it.

    * tests/electric-tests (electric-pair-test-for): comment out
c++-mode from the
    list of modes to be used in tests.
    (electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings)
    (ert-deftest electric-layout-int-main-kernel-style)
    (ert-deftest electric-layout-int-main-allman-style): Comment out.

I thought we had agreed that the way to "work around" other people's
unit tests, even if temporarily, is to work in a separate git branch.

The other electric-pair-test that I disabled 6 months ago, that was one that
also temporary, is till there. But now you destroyed even the "expected
failure" mark.  Why?? Is the test passing unexpectedly?

@@ -396,10 +397,10 @@ whitespace-chomping-2
 ;; mode will sort this out eventually, using some new e-p-m machinery.
 ;; See
 ;; https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00535.html
-(setf
- (ert-test-expected-result-type
-  (ert-get-test
'electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings))
- :failed)
+;; (setf
+;;  (ert-test-expected-result-type
+;;   (ert-get-test
'electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings))
+;;  :failed)

But this is much more intrusive.  In particular

;; Tests commented out, since C Mode does not use
;; electric-layout-mode.  2019-01-17, ACM

C Mode doesn't use electric-layout mode, but a user can surely
decide we wants to use it in c-mode, can he not??  These tests
pass fine currently.

Please revert this fix and lets discuss why you need to disable tests.

If we come to the conclusion that some tests are asserting unreasonable
expectations about the functionality you develop, we can disable them on a
case by case basis!

If on the other hand, if you need to do some work "temporarily", then
the best way to do it without disturbing other people's developments
is to do it in a separate branch.

João