|
From: | Tianxiang Xiong |
Subject: | Re: Performance issue w/ `cl-loop`s `collect...into` |
Date: | Sun, 8 Apr 2018 19:16:08 -0700 |
> Here's a second, cleaner attempt that separates the `cl--loop-handle-accum`
> function into two functions, one to deal with lists and one to deal w/
> non-lists.
> The tail-tracking optimizing is also applied to `append(ing)` and
> `nconc(ing)`.
Thanks. Looks good.
I see you've dropped the (eq var cl--loop-accum-var) optimization.
Have you tried to measure the effect?
Stefan
> +(defun cl--loop-handle-accum (def)
[...]
> + (cond
[...]
> + (cl--loop-accum-var cl--loop-accum-var)
You can write this line as just
(cl--loop-accum-var)
-- Stefan
0003-Optimize-collect.into.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |