emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 51c8369: Run secrets suite test when Emacs has dbus support


From: Michael Albinus
Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support
Date: Fri, 06 Apr 2018 10:04:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Tino Calancha <address@hidden> writes:

Hi Tino,

>> Why this? If there is no D-Bus support, secrets-enabled shall be nil,
>> and the tests shall skip (except secrets-test00-availability, which
>> shall fail). That's intended.
>
> I don't know.  I saw in our gitlab CI that your new test was failing:
> https://gitlab.com/emacs-ci/emacs/commits/master

I see, thanks. I'll try to reproduce it locally, and fix it
properly. For the future: if a test fails, pls report instead of
suppressing. That's what tests are good for :-)

>> FTR, this would be wrong. :expected-result must always be the first
>> clause in body.
>
> I see.  Could you please update this part? (Or anyother that you think
> might be wrong).

Will do.

> Thanks.
> Tino

Best regards, Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]