|
From: | Stefan Monnier |
Subject: | Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) |
Date: | Tue, 18 Jul 2017 09:41:42 -0400 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
> + ;; Update `this-command' and run `pre-command-hook' so that > + ;; things like `delete-selection-pre-hook' will work correctly. > + (setq this-command cmd) > + (run-hooks 'pre-command-hook) > ;; mouse-major-mode-menu was using `command-execute' instead. > (call-interactively cmd)))) Hmm... shouldn't it then also run post-command-hook, and set last-command (and probably a few more of the things done in the usual command loop, such as handling undo-boundaries)? IOW, we should move the C code which runs the commands from the command loop and make it available to Elisp. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |