[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Some testing issues
From: |
Stephen Berman |
Subject: |
Re: Some testing issues |
Date: |
Sat, 08 Jul 2017 16:52:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
On Sat, 08 Jul 2017 00:45:10 -0400 Stefan Monnier <address@hidden> wrote:
>> Several of the tests call the function todo-toggle-view-done-items,
>> which contains this code:
>>
>> (if (not (pos-visible-in-window-p shown))
>> (recenter)
>
> This code is indeed brittle: pos-visible-in-window-p presumes that
> (current-buffer) is the same as (window-buffer (selected-window)), but
> that's not always the case.
Is there a less brittle way to test the visibility of point? At least
as far as using todo-toggle-view-done-items in todo-mode in concerned,
(current-buffer) is equivalent to (window-buffer (selected-window)), but
apparently that is not so in the test environment.
Steve Berman
- Some testing issues, Stephen Berman, 2017/07/07
- Re: Some testing issues, Stefan Monnier, 2017/07/08
- Re: Some testing issues,
Stephen Berman <=
- Re: Some testing issues, Stefan Monnier, 2017/07/10
- Re: Some testing issues, Stephen Berman, 2017/07/14
- Re: Some testing issues, Stefan Monnier, 2017/07/14
- Re: Some testing issues, Stephen Berman, 2017/07/17
- Re: Some testing issues, Stefan Monnier, 2017/07/17
Re: Some testing issues, martin rudalics, 2017/07/08