[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 26.0.50; Extend dired-do-shell-command substitutions
From: |
Tino Calancha |
Subject: |
Re: 26.0.50; Extend dired-do-shell-command substitutions |
Date: |
Sat, 01 Jul 2017 14:06:01 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Tino Calancha <address@hidden> writes:
One thing i am not sure is that in my patch i delete
the two variables `dired-star-subst-regexp' and
`dired-quark-subst-regexp': they are just used in dired-aux.el
for the substitutions in `dired-do-shell-command':
> commit cd9877d16edec71e7ea9b1eedd4194d67c1b092e
> Author: Tino Calancha <address@hidden>
> Date: Tue Jun 27 00:18:45 2017 +0900
>
> Extend dired-do-shell-command substitutions
>
> Substitute "`?`" inside command with the current file name.
> * lisp/dired-aux.el (dired-quark-subst-regexp, dired-star-subst-regexp):
> Delete them.
> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index 121bebeb65..1265fe3501 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -49,8 +49,30 @@ dired-create-files-failures
> ;;;###begin dired-cmd.el
> ;; Diffing and compressing
>
> -(defconst dired-star-subst-regexp "\\(^\\|[ \t]\\)\\*\\([ \t]\\|$\\)")
> -(defconst dired-quark-subst-regexp "\\(^\\|[ \t]\\)\\?\\([ \t]\\|$\\)")
> +(defun dired-isolated-string-re (string)
> + "Return a regexp to match STRING isolated.
I am wondering if i should keep these variables in case some
code out there rely on them; something like adding a comment saying that
these vars are obsolete? Or is OK just to drop these vars?
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: 26.0.50; Extend dired-do-shell-command substitutions,
Tino Calancha <=