[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Support 24-bit terminal colors.
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH v2] Support 24-bit terminal colors. |
Date: |
Sun, 12 Feb 2017 22:47:24 +0200 |
> From: Rami Ylimäki <address@hidden>
> Date: Sun, 12 Feb 2017 12:05:27 +0200
>
> I have tested these changes on gnome-terminal/Ubuntu and iTerm2/OSX.
>
> Rami Ylimäki (3):
> Remove unused terminal color pair count.
> Support 24-bit terminal colors.
> Let user turn 24-bit terminal colors on.
>
> lisp/term/tty-colors.el | 19 +++++++++++++++++--
> lisp/term/xterm.el | 8 ++++++++
> src/term.c | 20 ++++++++++++++------
> src/termchar.h | 4 ----
> src/tparam.h | 4 ++++
> 5 files changed, 43 insertions(+), 12 deletions(-)
Thanks. This looks very good. A couple of comments:
. Please prepare a NEWS entry for this feature.
. It seems like you dropped the code to support the --color=
command-line argument, which was part of your original submission?
All the other color TTY modes support --color=NUM, so I think we
should also support --color=16777216, and perhaps also --color-24bit.
. If you agree to add the code for the previous item, the Emacs user
manual should need an update (node "Colors X", where the --color
option is described).
Thanks again for working on this.