Re: Patch for Emacs 25.2

[Michael Albinus]

Eli Zaretskii <address@hidden> writes:

Hi Eli,

> Do I understand correctly that fixing the bug introduced by e3a0f3d
> requires only the change in tramp.el?

That's correct.

> Regarding the other bug and its fix in files.el, can you tell more
> about the bug?  A change in files.el affects a very broad class of use
> cases, so I'd like to know more before I make up my mind about it.

In `make-auto-save-file-name', there is twice a test for ang-ftp file names:

--8<---------------cut here---------------start------------->8---
(not (string-match "^/address@hidden:" result)))
--8<---------------cut here---------------end--------------->8---

The regexp matches ange-ftp file names like "/address@hidden:". It does not
match general Tramp syntax, like "/method:address@hidden:" or "/host:". As
result, on MS Windows there is an error like

--8<---------------cut here---------------start------------->8---
(let ((buffer-file-name "/method:address@hidden:/path/to/file")
      tramp-auto-save-directory auto-save-file-name-transforms)
  (make-auto-save-file-name))

=> "address@hidden"
--8<---------------cut here---------------end--------------->8---

The patch replaces this regexp by 

--8<---------------cut here---------------start------------->8---
(not (file-remote-p result)))
--8<---------------cut here---------------end--------------->8---

Then it works as expected:

--8<---------------cut here---------------start------------->8---
(let ((buffer-file-name "/method:address@hidden:/path/to/file")
      tramp-auto-save-directory auto-save-file-name-transforms)
  (make-auto-save-file-name))

=> "/method:address@hidden:/path/to/#file#"
--8<---------------cut here---------------end--------------->8---

The patch is harmless enough that I propose it for Emacs 25.2.

> Thanks.

Best regards, Michael.