[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patches for Emacs 25.2
From: |
Eli Zaretskii |
Subject: |
Re: Patches for Emacs 25.2 |
Date: |
Tue, 18 Oct 2016 14:29:00 +0300 |
> From: Nikolay Kudryavtsev <address@hidden>
> Cc: address@hidden
> Date: Tue, 18 Oct 2016 14:05:46 +0300
>
> bug#23076 was wishlist, that's true. And it's fixed in 25.1 already. It's
> just that the fix introduces a separate problem breaking tramp git commits.
> That problem is NOT a wishlist. As for modified - the largest modified part
> in that commit is tramp-tests the rest are trivial changes to ob-core.el,
> vc-hooks.el, gud.el. If it's still too large, we can just take only that new
> tramp function, vc-git fix part(that depends on it) and use that. Even if the
> function is broken somehow, it would not break anything that is not already
> broken(tramp vc git commits).
The changeset adds 2 new functions, adds 2 new handlers, and uses
these handlers in several files. It also adds a defcustom, which
already makes it something other than just a bugfix, because it has
clear user-visible changes. The added code will most probably have
non-trivial consequences, given what it does and how many problems we
had in that area.
So I don't really see how you can claim that this changeset is safe
for 25.2.
Once again, if someone suggests a safer change that fixes the bug
without introducing new features, I will consider it for the release
branch. But that changeset in its present form is out of the question
for emacs-25, and Michael feels the same. Sorry. (People who must
have this change can always patch their local Tramp.)
- Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18
- Re: Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Nikolay Kudryavtsev, 2016/10/18
- Re: Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18
- Re: Patches for Emacs 25.2, Nikolay Kudryavtsev, 2016/10/18
- Re: Patches for Emacs 25.2,
Eli Zaretskii <=
- Re: Patches for Emacs 25.2, Nikolay Kudryavtsev, 2016/10/18
- Re: Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18
- Re: Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18
- Re: Patches for Emacs 25.2, Michael Albinus, 2016/10/18
- Re: Patches for Emacs 25.2, Eli Zaretskii, 2016/10/18