[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Small fix in `shell--unquote&requote-argument' - please review
From: |
Stefan Monnier |
Subject: |
Re: Small fix in `shell--unquote&requote-argument' - please review |
Date: |
Thu, 08 Sep 2016 16:23:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
> 1. (shell--unquote&requote-argument "te'st" 2)
>
> This produces `("testst" 2 comint-quote-filename)'.
>
> Having found first `'', `string-match' cannot find closing quote.
> Then (match-end 0) is used, it's value is "undefined", but happens to
> be 3, so we duplicate last 2 chars and that's wrong.
>
> 2. (shell--unquote&requote-argument "test'" 2)
>
> This produces `("test" 2 comint-quote-filename)'.
>
> First `'' happens to be at the end of line. The condition
>
> `(< match (1+ (length qstr)))'
OK, great, that looks very helpful.
I'll take a look at the patch ASAP,
Stefan