Re: Embedded modifiers in the regex engine

[Dima Kogan]

Eli Zaretskii <address@hidden> writes:

>> > What's wrong with the existing one?
>> 
>> Maybe nothing. I'd like to add a feature, but if there are plans to
>> abandon the current implementation, then I want to add my feature to
>> whatever the new implementation is.
>
> AFAIK, no one works on replacing the current implementation.  So we
> should talk about the changes first, and worry about replacing the
> current code later.

OK. I'll go back to look at my earlier work to add the feature to the
current implementation.


>> > Also, please provide log messages for the changes.
>> 
>> What kind of log messages? Git logs? These are terse because this
>> project seems to have strict guidelines, and other messages I see are
>> generally very terse. What would you like?
>
> See CONTRIBUTE: they should be Git log messages in the ChangeLog
> format.

Can you please be more specific about what is missing in the patches I
sent?

Thanks
dima