[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non
From: |
Stephen Leake |
Subject: |
Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace |
Date: |
Tue, 27 Oct 2015 20:51:42 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) |
Juanma Barranquero <address@hidden> writes:
> This will be my first ERT test, so, does the following (attached, because
> Gmail) patch look acceptable?
Looks good to me, except see below.
> And, it is possible to commit a file with trailing whitespace?
Yes, but it's also very easy to lose it, thus breaking the test. I
suggest instead to save the file without extra whitespace, and add code
to the test to insert the extra whitespace. That way you can also add
comments about why this test exists, etc.
--
-- Stephe