Re: Dynamic loading progress

[Philipp Stephani]

Aurélien Aptel <address@hidden> schrieb am So., 4. Okt. 2015 um 15:25 Uhr:

First of all thank you for actually contributing with code, Philip.
Very much appreciated.

On Mon, Sep 28, 2015 at 5:35 PM, Philipp Stephani <address@hidden> wrote:
> I have implemented this in a private fork:
> https://github.com/phst/emacs-dynamic-module/commit/b14073ef8a522bdb90a8d7f0edc575edfd75da26
> Note that code is only a suggestion how it could be implemented. It deviates
> from Daniel's design by using return parameters instead of TLS, but that's
> only a minor difference. The important part is the addition of
> protected_call_n to eval.c.

I've looked at both branch. The one using an in-out return parameter
looks really annoying to use though. I think I prefer the "minimal"
implementation [1].

That's fine, it's Daniel's design, after all, and using TLS for error reporting is common (e.g. errno). I've added a pull request for this: https://github.com/aaptel/emacs-dynamic-module/pull/7

Another pull request implements checking whether calls are only made on the main thread: https://github.com/aaptel/emacs-dynamic-module/pull/8

 

Using that version, we could add an
unsafe_funcall() to the API that doesnt do any signal checking so that
we have both.

Daniel, what do you think about that?