[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el.
From: |
Paul Eggert |
Subject: |
Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el. |
Date: |
Wed, 03 Dec 2014 11:41:40 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/03/2014 11:27 AM, Eric S. Raymond wrote:
You want it even when the ChangeLog part is a trivial
repetition of the summary line?
It's not needed for one-liners. For commit
e820f16c06a5a6be4bc87910b349c7c3c6eca0f4, for example, your ChangeLog
entry was "* files.el (file-tree-walk): Lisp translation of ANSI
ftw(3).", and that one-liner should have been the git commit message, too.
For longer messages, please use the same text for both the ChangeLog
file as for the commit message, except omit the 2nd-blank-line in the
former and omit the leading tabs in the latter. For commit
b1a765b3a8586cd53c21579982c8fbc0ce534336, in contrast, it would have
been better to use the following text (removing indentation) as the
commit message:
In vc, abolish the dir-status method.
* vc.el, all backends: API simplification: Abolish dir-status.
It's replaced by dir-status-files.
and to use the same text (with indentation, but without the blank line)
as the ChangeLog entry.
It is a pain to have to have essentially two copies of the same text,
one in the ChangeLog file and the other in the commit message, but we
haven't yet had strong consensus on fixing this.
Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el., Eric S. Raymond, 2014/12/03
- Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el.,
Paul Eggert <=
- Commit comment rules - and a metaproblem, Eric S. Raymond, 2014/12/03
- Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el., Eli Zaretskii, 2014/12/03
- More metaproblem, Eric S. Raymond, 2014/12/03
- Re: More metaproblem, Karl Fogel, 2014/12/03
- Re: More metaproblem, Eli Zaretskii, 2014/12/04
- Re: More metaproblem, Stephen Leake, 2014/12/04
- Re: More metaproblem, Eli Zaretskii, 2014/12/04
- Re: More metaproblem, David Kastrup, 2014/12/04
- Re: More metaproblem, Stefan Monnier, 2014/12/04
- Re: More metaproblem, Stephen Leake, 2014/12/04