[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r115470: eww: exit and close actions
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] trunk r115470: eww: exit and close actions |
Date: |
Thu, 12 Dec 2013 13:52:48 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> +(defun eww-exit ()
> + "Exit the Emacs Web Wowser."
> + (interactive)
> + (setq eww-history nil)
> + (kill-buffer (current-buffer)))
> +
> +(defun eww-close ()
> + "Close the Emacs Web Wowser browser, leaving history intact."
> + (interactive)
> + (quit-window))
I think this is a step backward. The names `eww-close' and `eww-exit'
don't help the user understand what those commands do. To me they sound
like different names for the same thing.
I'd rather use commands `kill-this-buffer' and `quit-window' which are
much more clear and which the user might already know.
I'm not sure how (setq eww-history nil) fits in there, because I don't
know why it's there, so I can't comment on how best to go about it in
this respect.
Stefan
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions,
Stefan Monnier <=
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Ted Zlatanov, 2013/12/12
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Stefan Monnier, 2013/12/12
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Ted Zlatanov, 2013/12/13
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Stefan Monnier, 2013/12/13
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Ted Zlatanov, 2013/12/13
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Stefan Monnier, 2013/12/13
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Ted Zlatanov, 2013/12/14
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Lars Magne Ingebrigtsen, 2013/12/14
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, T.V. Raman, 2013/12/15
- Re: [Emacs-diffs] trunk r115470: eww: exit and close actions, Ted Zlatanov, 2013/12/16