[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Make `C-x {' and `C-x }' repeatable
From: |
Drew Adams |
Subject: |
RE: [PATCH] Make `C-x {' and `C-x }' repeatable |
Date: |
Wed, 22 May 2013 16:53:55 -0700 (PDT) |
> >> I want to have a repeatable command bound to a key on `isearch-mode-map'.
>
> Of course. Bug#14095 is a clear bug
That's reassuring; thanks. As no one had yet had a chance to respond
to the bug report, I wasn't sure that you would see it that way.
> linked to the following comment in set-temporary-overlay-map:
>
> ;; FIXME: That's the keymaps with highest precedence, except for
> ;; the `keymap' text-property ;-(
>
> the bug is actually wrong,
Do you mean that comment or the bug #14095 report?
> because additionally to the `keymap'
> property, overriding-local-map and overriding-terminal-local-map are two
> more keymaps of higher precedence. So the right fix for it is to
> introduce a new keymap (call it "overriding-temporary-local-map" or
> something) which is like overriding-terminal-local-map except that it
> doesn't disable other keymaps (it just has higher precedence).
Sounds good to me (with limited understanding).
> > Maybe a better implementation would be with the help of
> > `set-temporary-overlay-map'. I'll try to do this for Isearch.
>
> Isearch might benefit from being changed to use such a new
> overriding-temporary-local-map as well. It might let us drop the
> isearch-other-char command (which has the drawback of putting things
> back onto unread-command-event, which is inherently unreliable in the
> presence of some function-key-map bindings, among other problems).
> Of course, such a change might also bump into new problems.
A priori, that too sounds good to me (again, with limited understanding).
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, (continued)
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Drew Adams, 2013/05/22
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, chad, 2013/05/22
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Drew Adams, 2013/05/23
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/23
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Drew Adams, 2013/05/23
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Stephen J. Turnbull, 2013/05/24
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Drew Adams, 2013/05/24
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable, Stephen J. Turnbull, 2013/05/24
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/22
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/22
- RE: [PATCH] Make `C-x {' and `C-x }' repeatable,
Drew Adams <=
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Juri Linkov, 2013/05/23
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/23
Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/22
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Gauthier Östervall, 2013/05/23
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Stefan Monnier, 2013/05/23
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Juri Linkov, 2013/05/23
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Alan Mackenzie, 2013/05/24
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Juri Linkov, 2013/05/24
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Alan Mackenzie, 2013/05/25
- Re: [PATCH] Make `C-x {' and `C-x }' repeatable, Juri Linkov, 2013/05/25