[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix for bug 10994 breaks ido customizations in major way
From: |
Óscar Fuentes |
Subject: |
Re: fix for bug 10994 breaks ido customizations in major way |
Date: |
Sun, 05 May 2013 12:57:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Le Wang <address@hidden> writes:
> The only way to introduce list with dupes is ido-completing-read (i.e. it's
> not an issue for files and buffers), so I think it's okay to remove dupes
> just once on entry.
>
> Patch atached.
diff --git a/lisp/ido.el b/lisp/ido.el
index bedf00e..15e280e 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -3159,8 +3159,7 @@ Use `eq' for comparison."
(sofar nil))
(while (not ret)
(setq next (car items))
- ;; Use `eq' to avoid bug http://debbugs.gnu.org/10994
- (if (eq next elem)
+ (if (equal next elem)
(setq ret (append items (nreverse sofar)))
;; else
(progn
@@ -4795,7 +4794,7 @@ DEF, if non-nil, is the default value."
(ido-directory-nonreadable nil)
(ido-directory-too-big nil)
(ido-context-switch-command 'ignore)
- (ido-choice-list choices))
+ (ido-choice-list (delete-dups choices)))
;; Initialize ido before invoking ido-read-internal
(ido-common-initialization)
(ido-read-internal 'list prompt hist def require-match initial-input)))
Tried it and seems to work fine for both flx and the original ido bug
report about C-s/C-r with duplicates.
Leo, what do you think?
- fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/02
- Re: fix for bug 10994 breaks ido customizations in major way, Leo Liu, 2013/05/03
- Re: fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/03
- Re: fix for bug 10994 breaks ido customizations in major way, Leo Liu, 2013/05/03
- Re: fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/04
- Re: fix for bug 10994 breaks ido customizations in major way, Óscar Fuentes, 2013/05/04
- Re: fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/04
- Re: fix for bug 10994 breaks ido customizations in major way,
Óscar Fuentes <=
- Re: fix for bug 10994 breaks ido customizations in major way, Leo Liu, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Óscar Fuentes, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Leo Liu, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Óscar Fuentes, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Stephen J. Turnbull, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Óscar Fuentes, 2013/05/05
- Re: fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/06
- Re: fix for bug 10994 breaks ido customizations in major way, Vitalie Spinu, 2013/05/06
- Re: fix for bug 10994 breaks ido customizations in major way, Óscar Fuentes, 2013/05/06
- Re: fix for bug 10994 breaks ido customizations in major way, Le Wang, 2013/05/07