Re: [PATCH] OS X: make configure work better out of the box with FSF GCC

[Glenn Morris]

Daniel Colascione wrote:

> I didn't include the corresponding configure changes; I figure I can let
> whoever installs this patch regenerate the script.

Could you explain what problem this change is supposed to fix?

> +    case "$(which "${CC-cc}")" in
> +      /usr/bin/* | /usr/lib/* )
> +        CPP="${CC-cc} -E -no-cpp-precomp"
> +        ;;
> +      * )
> +        # The below macro prevents the Carbon headers from defining
> +        # nonstandard constructs not understood by FSF GCC.
> +        CPPFLAGS="$CPPFLAGS -D__INTEL_COMPILER=1"
> +        CPP="${CC-cc} -E -D__INTEL_COMPILER=1"

"FSF GCC" seems tautological at best.

It seems fragile to test the location of the compiler. Why not test for
the actual compiler version?