Re: Pretest compilation problem

[Chong Yidong]

Andreas Schwab <address@hidden> writes:

> Glenn Morris <address@hidden> writes:
>
>> Chong Yidong wrote:
>>
>>> Adding $(CFLAGS) sounds correct,
>>
>> ALL_CFLAGS used to be there in Emacs 23.1. It was removed in r1.461,
>> 2009-12-16, by Andreas ("Don't compile prefix-args.c twice.")
>> I'm sure he will be happy to provide a detailed explanation.
>
> Since it's no longer compiling there is no need for CFLAGS any more.

Strictly speaking, you're correct.  But passing CFLAGS apparently does
no harm.  As for the statement that -m32 belongs in CC, I doubt that
most people make that distinction between -m32 and other arguments to
the compiler; at the very least, it is surprising requirement for us to
make.

Unless anyone can come up with a specific example where adding CFLAGS to
this rule causes compilation to do the wrong thing, I'll put it back.