[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "RGB" in color.el
From: |
Detlev Zundel |
Subject: |
Re: "RGB" in color.el |
Date: |
Thu, 02 Dec 2010 16:01:24 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Hello Julien,
> On Fri, Nov 26 2010, Miles Bader wrote:
>
>> I think the comments in color.el should be a bit more specific about the
>> term "RGB", since that's ambiguous (e.g., in `color-xyz->rgb', the
>> comment just says "Converts CIE X Y Z colors to RGB.").
>>
>> From the code it's pretty clear that what's really meant is "sRGB" so
>> maybe that term could just be substituted.
>
> You are right.
> I've fixed that, but feel free to come with something even better.
You have missed one rename which bit me just now. The attached patch
fixes that.
Thanks
Detlev
--
Of course my password is the same as my pet's name
My macaw's name was Q47pY!3 and I change it every 90 days
-- Trevor Linton
>From 43a16ab206e58c596dfe7c5819108e81926b703c Mon Sep 17 00:00:00 2001
From: Detlev Zundel <address@hidden>
Date: Thu, 2 Dec 2010 15:57:58 +0100
Subject: [PATCH] The recent rename of functions missed renaming one call.
Signed-off-by: Detlev Zundel <address@hidden>
---
lisp/gnus/color.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/gnus/color.el b/lisp/gnus/color.el
index 4d3718b..d22a71f 100644
--- a/lisp/gnus/color.el
+++ b/lisp/gnus/color.el
@@ -196,7 +196,7 @@ none is set, `color-d65-xyz' is used."
(defun color-lab->srgb (L a b)
"Converts CIE L*a*b* to RGB."
- (apply 'color-xyz->rgb (color-lab->xyz L a b)))
+ (apply 'color-xyz->srgb (color-lab->xyz L a b)))
(defun color-cie-de2000 (color1 color2 &optional kL kC kH)
"Computes the CIEDE2000 color distance between COLOR1 and COLOR2.
--
1.7.2.3