Re: MS-Windows build broken in Fmake_network_process

[Eli Zaretskii]

> From: Chong Yidong <address@hidden>
> Cc: Helmut Eller <address@hidden>, address@hidden
> Date: Fri, 26 Mar 2010 20:48:52 -0400
> 
> Eli Zaretskii <address@hidden> writes:
> 
> > Solution for what?  The previous code had no problems on Windows.  The
> > bug report that triggered the new code was deeply rooted in Posix
> > behavior; the solution is Posix-centric code, and was never tested on
> > Windows.  Why should it be run on Windows, and what ``problem'' will
> > that solve?
> 
> I conditioned the patch out for WINDOWSNT, for now, to avoid breaking
> the Windows build.

Thank you, it now builds again.

> However, could you investigate whether we could link in getsockopt in
> the Windows build?

Yes, we could (it just needs an additional -lws2 switch during
linking), assuming Someone(TM) knows how to resolve the issue with
incompatible pointers in the 4th arg (see my original report about the
broken build).  But what would this be good for, if we don't
understand the effect the added code will have on Windows?

> Although the original bug recipe in Bug#5173 does not look relevant
> to Windows, Bug#5723 might be.

I'm probably missing something, because the fix for Bug#5723 was
applied to the Windows build as well, and I can see no issues with
it.  That fix was about not starting atimers around the call to
`connect'.  How is this relevant to `getsockopt'?