Re: vc-git bug in vc-dir

[Dan Nicolaescu]

Tom Tromey <address@hidden> writes:

  > >>>>> "Dan" == Dan Nicolaescu <address@hidden> writes:
  > 
  > Dan> Eric Hanchrow posted a patch in Bug#1589 that fixes this by using a
  > Dan> git option available in git after version 1.5.5 (which
  > Dan> was released in April 2008)
  > 
  > Dan> Should we check in this fix?
  > 
  > Dan> What do git users think?
  > 
  > It seems to me that if it fails nicely with older versions of git --
  > saying what the problem is and how to work around it -- then the patch
  > should definitely go in.

It does not fail nicely.
So there's a trade off: vc-dir fails with old versions (we can document
that in NEWS), or it fails all the time (as it currently does).
IMHO dealing nicely with old version is not worth the effort and added
code gunk (plus volunteers to do it are hard to find).