[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Carbon port and multi-tty
From: |
Dan Nicolaescu |
Subject: |
Re: Carbon port and multi-tty |
Date: |
Tue, 06 May 2008 22:55:12 -0700 |
YAMAMOTO Mitsuharu <address@hidden> writes:
> >>>>> On Tue, 06 May 2008 21:28:37 -0700, Dan Nicolaescu <address@hidden>
said:
>
> >> It actually introduced a bug in the part that is unrelated to
> >> multi-tty.
>
> > Please show us the exact bug, and I'll fix it or back out the
> > change. Had this information been available, this would have
> > happened a year ago.
>
> The change corresponds to this entry:
>
> 2007-08-29 Dan Nicolaescu <address@hidden>
>
> (Fx_create_frame): Fix doc string. Rename the parameter. Set the
> frame parameters following what is done in X11 and w32.
>
> Actually the comment was not right. This has changed the Mac code
> from what is done in X11 to what is done in W32.
You mean the ChangeLog entry? I used both X11 and w32 as inspiration.
There was an incorrect comment talking about an inexistent ALIST
parameter that the original patch fixed.
> The bug introduced by this change is mentioned here:
> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01069.html
OK, a 1 line change (in a ~1000 lines patch) that you seemed to have
known about for a while.
Interesting choice of action: raising all this hell instead of just
fixing it. Fine, if your judgment tells you such a behavior is wise...
> And the following change is totally unrelated to multi-tty.
>
> (mac_window): Add 2 new parameters for consistency with other systems.
>
> Again, the comment was not right. The X11 counterpart (x_window) has
> several versions, one of which has only one argument as in the
> original mac_window.
This has not functional value, just esthetic, it has zero effect on
functionality. I changed it anyway.
> There might be others, but the above is what I could find.
Please find them, if they actually exist.
- Re: Carbon port and multi-tty, (continued)
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/06
- Re: Carbon port and multi-tty, Stefan Monnier, 2008/05/06
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/06
- Re: Carbon port and multi-tty, Nick Roberts, 2008/05/06
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/07
- Re: Carbon port and multi-tty, Stefan Monnier, 2008/05/07
- Re: Carbon port and multi-tty, David Kastrup, 2008/05/07
- Re: Carbon port and multi-tty, Eli Zaretskii, 2008/05/07
- Re: Carbon port and multi-tty, Dan Nicolaescu, 2008/05/07
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/07
- Re: Carbon port and multi-tty,
Dan Nicolaescu <=
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/07
- Re: Carbon port and multi-tty, David Kastrup, 2008/05/07
- Re: Carbon port and multi-tty, YAMAMOTO Mitsuharu, 2008/05/07
- Re: Carbon port and multi-tty, Stephen J. Turnbull, 2008/05/07
- Re: Carbon port and multi-tty, David Kastrup, 2008/05/07
- Re: Carbon port and multi-tty, Eli Zaretskii, 2008/05/07
- Re: Carbon port and multi-tty, David Kastrup, 2008/05/07
- Re: Carbon port and multi-tty, Eli Zaretskii, 2008/05/07
- Re: Carbon port and multi-tty, David Kastrup, 2008/05/07
- Re: Carbon port and multi-tty, Eli Zaretskii, 2008/05/07