Re: capslock changes control characters?

[Andreas Schwab]

Stefan Monnier <address@hidden> writes:

>> 2008-03-05  Kenichi Handa  <address@hidden>
>
>>      * lread.c (Fread_char): Resolve modifiers.
>>      (Fread_char_exclusive): Likewise.
>
>> Previously (read-char) returned 33554441 when you type C-I
>> (i.e. C-S-i).  I changed it to return 9 (i.e. C-i).  It is
>> also changed to return 233 upon M-i instead of 134217833.
>> They still return a code containing unresolvable modifiers.
>
> It looks ok, but I have some comments/questions:
>
> 1 - Why both with the mapping of meta?  AFAIK this is only ever used
>     when manipulating keymaps using keysequences represented as strings
>     rather than vectors.  So I don't think it's needed here.
>
> 2 - why is this needed now.  It seems like this was already working fine
>     before the unicode merge without this function, so what is the change
>     that caused the problem in the first place (or in other words, how
>     did it work before)?

(read-char) has always returned 33554441 for C-S-i.  I think the
difference is that it is no longer considered a valid character by
char-or-string-p (ie. CHARACTERP).

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."