emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: remember-region should be autoloaded


From: Lennart Borgman (gmail)
Subject: Re: remember-region should be autoloaded
Date: Wed, 19 Dec 2007 12:15:23 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666

Ryan Yeske wrote:
I usually use M-x remember-region to record notes from text in my emacs
buffers.


2007-12-19  Ryan Yeske  <address@hidden>

        * textmodes/remember.el (remember-region): Add autoload cookie.


diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
index 81be7ac..01d1954 100644
--- a/lisp/textmodes/remember.el
+++ b/lisp/textmodes/remember.el
@@ -419,6 +419,7 @@ Subject: %s\n\n"
               (when remember-save-after-remembering (save-buffer))))
         (append-to-file (point-min) (point-max) remember-data-file)))))
+;;;###autoload
 (defun remember-region (&optional beg end)
   "Remember the data from BEG to END.
 It is called from within the *Remember* buffer to save the text


Diffs between working revision and workfile end here.

In my version of remember.el remember-region is already autoloaded, but it looks to me from the doc string like it should not be that since it is meant to be called from the *Remember* buffer.

However there is a small bug in remember in the way it handles the region. Beside that it would be nice if it used the region when it is visible. Something like this in the beginning of remember:

(defun remember (&optional initial)
  "Remember an arbitrary piece of data.
With a prefix or a visible region, uses the region as INITIAL."
  (interactive
   (list (when (or current-prefix-arg
                   (and mark-active
                        transient-mark-mode))
           (buffer-substring-noproperties
            (region-beginning) (region-end)))))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]